Skip to content

Conversation

@DTrim99
Copy link
Collaborator

@DTrim99 DTrim99 commented Jan 12, 2026

Summary

Update Hawaii income tax implementation for tax year 2025. This PR:

  • Adds 2025 references with page numbers to all Hawaii income tax parameters
  • Verifies parameter values against 2025 tax forms
  • Adds 2025 integration tests for new bracket thresholds (H.B. 2404)

Fixes #7156

Status

  • Tax rates with 2025 references
  • Credits (EITC, CDCC, Food/Excise, LIHRTC) with 2025 references
  • Deductions, exemptions, subtractions with 2025 references
  • Integration tests for 2025 tax year
  • CI passing

Key 2025 Changes

Per H.B. 2404, Hawaii enacted significant tax bracket changes effective January 1, 2025.

Files Changed

  • 35 parameter files with 2025 references added
  • 1 integration test file with 7 new 2025 test cases
  • Changelog entry added

Generated with Claude Code

DTrim99 and others added 2 commits January 12, 2026 13:41
Starting implementation of Hawaii 2025 income tax updates.
Documentation and parallel development will follow.

Co-Authored-By: Claude Opus 4.5 <[email protected]>
Added 2025 Hawaii tax form references to parameter metadata and
comprehensive integration tests for H.B. 2404 widened tax brackets.

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@DTrim99 DTrim99 marked this pull request as ready for review January 12, 2026 21:25
@DTrim99
Copy link
Collaborator Author

DTrim99 commented Jan 12, 2026

Review Summary

This PR has been reviewed and is ready to merge.

Changes Reviewed:

  • 36 files modified: Added 2025 Hawaii tax form references to parameter metadata
  • 7 new integration tests: Comprehensive tests for H.B. 2404 widened tax brackets across all filing statuses

Verification:

  • make format - All files properly formatted
  • ✅ All 220 Hawaii tests pass
  • ✅ Changelog entry added

Test Coverage:

The new 2025 tests cover:

  • Single filers at multiple income levels and bracket boundaries
  • Joint filers with the widened brackets
  • Head of household mid-range income
  • Married filing separately in upper brackets
  • Surviving spouse in top brackets

All tax calculations verified against the 2025 N-11 Instructions (page 48).

@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.46%. Comparing base (c18ebd3) to head (93b0c11).
⚠️ Report is 34 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##              main    #7157       +/-   ##
============================================
- Coverage   100.00%   72.46%   -27.54%     
============================================
  Files            2     3665     +3663     
  Lines           22    52701    +52679     
  Branches         0      263      +263     
============================================
+ Hits            22    38189    +38167     
- Misses           0    14497    +14497     
- Partials         0       15       +15     
Flag Coverage Δ
unittests 72.46% <ø> (-27.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DTrim99 DTrim99 requested a review from hua7450 January 14, 2026 14:17
Copy link
Collaborator

@hua7450 hua7450 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor changes, then it looks good.

changes:
changed:
- title: Update Hawaii income tax parameters with 2025 references
description: Added 2025 form references to Hawaii income tax parameters including tax rates, exemptions, standard deductions, itemized deductions, credits (CDCC, EITC, food excise tax, LIHRTC), and subtractions. Added integration tests for 2025 H.B. 2404 widened tax brackets across all filing statuses.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove description in changelog_entry

label: Hawaii disability exemption amount
reference:
- title: 2022 Hawaii Resident Income Tax Instructions #page 20, line 25
- title: 2025 Hawaii Resident Income Tax Instructions page 20, line 25
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove page number in title

- Remove description from changelog entry
- Remove page numbers from reference titles in disabled.yaml

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@DTrim99
Copy link
Collaborator Author

DTrim99 commented Jan 15, 2026

Addressed review comments:

  • Removed description from changelog entry
  • Removed page numbers from reference titles in disabled.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Hawaii 2025 Individual Income Tax Model

2 participants